[Website] Tweak confirmations copy and placement. And preserve the Playground URL through settings update. - #4150
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Clarifies several Dock-related UX flows (delete/run/save/runtime reload) by improving notifications, preserving context across runtime reboots, and making saved-location info explicit in menus.
Changes:
- Add “success” status to Dock operation notices and auto-dismiss success toasts.
- Persist and restore the current WordPress URL after runtime settings changes/reboot.
- Improve saved playground row menus and delete-modal messaging to better explain outcomes.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/website/src/lib/state/redux/slice-ui.ts | Adds status to Dock operation notice model to support success toasts. |
| packages/playground/website/src/lib/state/redux/slice-sites.ts | Persists a URL to restore after runtime settings changes. |
| packages/playground/website/src/lib/state/redux/site-management-api-middleware.ts | Captures current URL before runtime reboots and stores it in site metadata. |
| packages/playground/website/src/lib/state/redux/boot-site-client.ts | Restores stored URL after reboot, then clears the restore flag. |
| packages/playground/website/src/lib/state/redux/boot-site-client.spec.ts | Adds coverage for reopening the previous page after runtime reboot. |
| packages/playground/website/src/components/saved-playgrounds-panel/index.tsx | Keeps a disabled “saved location” item in row menus. |
| packages/playground/website/src/components/dock/style.module.css | Adds success styling for Dock operation toast. |
| packages/playground/website/src/components/dock/dock.tsx | Auto-dismisses success notices; adjusts ARIA roles/labels; adds success styling hook. |
| packages/playground/website/src/components/delete-site-modal/index.tsx | Adds info notice explaining what happens after deletion (esp. active tab). |
| packages/playground/website/src/components/blueprint-editor/BlueprintBundleEditor.tsx | Shows a Dock-level success toast when running a Blueprint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
force-pushed
the
adamziel/fellyph-tibi-dock-followups
branch
6 times, most recently
from
July 21, 2026 21:34
e96b635 to
87572ba
Compare
adamziel
force-pushed
the
adamziel/fellyph-tibi-dock-followups
branch
from
July 21, 2026 22:41
87572ba to
40e6cdb
Compare
adamziel
force-pushed
the
adamziel/fellyph-tibi-dock-followups
branch
from
July 21, 2026 23:04
40e6cdb to
f5c417f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polishes four rough edges in the Dock.
The delete confirmation now names the destructive action in the button: "Delete Playground". It does not explain where the app goes after deletion; the app should just pick the next sensible Playground.
Running a Blueprint from the editor now posts a Dock-level success toast. That matters on narrow screens because the editor closes before the user can see inline feedback.
Saved Playground menus keep a disabled "Saved in browser storage" or "Saved in a local directory" row, so the menu still says why the save action is gone.
Runtime setting changes now reopen the WordPress page the user was on after PHP or networking restarts. The URL is kept only in transient Redux state. Before restoring it, the browser URL parser checks that it still belongs to the same Playground, so query strings such as
?slashes=///survive while protocol-relative or backslash-normalized external URLs are ignored.Testing
Delete a Playground and check that the confirm button says "Delete Playground". Run a Blueprint from the editor on a narrow viewport and check for a success toast. Open a saved Playground row menu and check that it says where the Playground is saved. Open a wp-admin page, change the PHP version, and check that the same page reopens after the runtime reload.