Feature/custom cadences#196
Open
olaservo wants to merge 3 commits into
Open
Conversation
Adds a flexible "Every N weeks on [Day]" recurring-event option alongside
the existing weekly/biweekly/monthly/yearly presets, so templates can repeat
at any week interval (e.g. every 3 weeks).
- Migration: add nullable recurrence_interval_count to events + event_revisions
- Event model: new weekly_n case in recurrence_description /
recurrence_date_interval (P{n}W) / recurrence_end_datetime (n*5 week
lookahead); register recurrence_interval_count as editable
- EventController: persist + validate the count (required_if weekly_n) in
create_event and save_event
- Views: dropdown option + revealed number input, with JS toggle/restore
- Tests: unit coverage for interval, lookahead window, and weekly fallback
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Generated recurrence instances are replicated from the template, which also copied recurrence_interval_count. The instance's recurrence_interval was already nulled, so the leftover count was an orphan value (never read, since all recurrence methods guard on recurrence_interval). Null it alongside recurrence_interval for consistent instance data. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The count input in the recurring-event details form submits even when hidden, so saving a template with a non-weekly_n cadence stored a stray count. Null it out unless the interval is weekly_n, and fall back to 1 in the description when the count is missing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some MCP groups meet every N weeks on a custom cadence that doesn't match either weekly or bi-weekly (such as MCP Apps). This PR adds an option to set recurring events to every N weeks.
The workaround we use today: we create a weekly meeting, and then delete the occurrences we don't want. That is a little awkward (and the events also tend to re-create themselves which cases confusion).
Side note, if you'd prefer I try to fix the problem where deleted events come back from the dead, let me know and I can dig into that one instead. That would let us keep using the workaround rather than potentially cluttering the UI with too many niche features.
Thanks!