fix(csv-parse): preserve multi-byte record delimiter in raw output#491
Open
Jian-Zhang08 wants to merge 1 commit into
Open
fix(csv-parse): preserve multi-byte record delimiter in raw output#491Jian-Zhang08 wants to merge 1 commit into
Jian-Zhang08 wants to merge 1 commit into
Conversation
With { raw: true }, only the first byte of the record delimiter was
appended to the raw buffer (in the per-char loop), and the parser then
advanced pos past the remaining delimiter bytes before emitting the
record. For multi-byte delimiters such as Windows "\r\n" this dropped
the trailing byte, so raw was 'a,b\r' instead of 'a,b\r\n'.
Append the remaining record-delimiter bytes to the raw buffer when a
delimiter is detected, so multi-byte delimiters are preserved in full.
Single-byte delimiters are unaffected (the loop body does not run).
Adds a regression test and rebuilds dist.
Fixes adaltas#332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With { raw: true }, only the first byte of the record delimiter was appended to the raw buffer (in the per-char loop), and the parser then advanced pos past the remaining delimiter bytes before emitting the record. For multi-byte delimiters such as Windows "\r\n" this dropped the trailing byte, so raw was 'a,b\r' instead of 'a,b\r\n'.
Append the remaining record-delimiter bytes to the raw buffer when a delimiter is detected, so multi-byte delimiters are preserved in full. Single-byte delimiters are unaffected (the loop body does not run).
Adds a regression test and rebuilds dist.
Fixes #332