Skip to content

Set the image cache when img is loaded #5778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmarcos merged 2 commits into from
Dec 18, 2025
Merged

Set the image cache when img is loaded #5778

dmarcos merged 2 commits into from
Dec 18, 2025

Conversation

@vincentfretin
Copy link
Contributor

@vincentfretin vincentfretin commented Dec 16, 2025 •
edited
Loading

Set the image cache when img is loaded to avoid a potential non resolving issue if the same img url is loaded via ImageLoader, as discussed in #5776 (comment)

Also use THREE.Cache methods instead of accessing directly THREE.Cache.files in tests.
@vincentfretin vincentfretin mentioned this pull request Dec 16, 2025
Merged
@vincentfretin vincentfretin changed the title Use THREE.Cache methods instead of accessing directly THREE.Cache.files in tests Dec 17, 2025
@dmarcos dmarcos merged commit 835aac4 into aframevr:master Dec 18, 2025
1 check passed
@dmarcos
Copy link
Member

dmarcos commented Dec 18, 2025

thanks!
@vincentfretin vincentfretin deleted the use-cache-public-api branch December 18, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@vincentfretin @dmarcos @connected79412