feat: add per-user unique IPs metric for key sharing detection#320
Open
oruchkin wants to merge 1 commit intoalexbers:masterfrom
Open
feat: add per-user unique IPs metric for key sharing detection#320oruchkin wants to merge 1 commit intoalexbers:masterfrom
oruchkin wants to merge 1 commit intoalexbers:masterfrom
Conversation
Add mtprotoproxy_user_unique_ips gauge metric that tracks the number of unique source IPs currently connected per user/secret. This helps proxy operators detect key sharing - if a single secret has connections from many different IPs, it likely means the key was shared with multiple people. Changes: - Track active connections per (user, source_ip) pair - Export user_unique_ips gauge via Prometheus metrics endpoint - Zero overhead: single dict lookup per connect/disconnect
Author
|
This is how it works in Grafana: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mtprotoproxy_user_unique_ips gauge metric that tracks the number of unique source IPs currently connected per user/secret.
This helps proxy operators detect key sharing - if a single secret has connections from many different IPs, it likely means the key was shared with multiple people.
Changes:
Usage
Prometheus / Grafana
Query to monitor unique IPs per user:
mtprotoproxy_user_unique_ips