feat: add support for custom tags in tracing configuration #3099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangyy93
requested review from
CH3CHO,
SpecialYang and
johnlanni
as code owners
|
|
Signed-off-by: yangyang <yang.yang@daocloud.io>
Author
已经增加相关e2e测试
Related e2e tests have been added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
在配置链路时新增自定义标签的选项，有以下逻辑：
当链路追踪开启时生效，默认为空
支持添加多个自定义标签，每个自定义标签的key不能为空且不能重复。
自定义标签的值分为固定值，从环境变���获取，从请求头中获取，而且值的获取方式只能选择其中一个。从环境变量获取和请求头中获取时可以设置默认值。值不允许为空。
Ⅱ. Does this pull request fix one issue?
fixes #3098
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews