feat: improve ingress sorting #3337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y variants and add codebase analysis documentation.
Aias00
requested review from
CH3CHO,
SpecialYang and
johnlanni
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes ingress sorting to ensure base ingress resources are prioritized over canary variants when they have the same creation timestamp. The sorting key is changed from Name.Namespace to Namespace.Name format.
Changes:
- Modified sorting logic to use
Namespace.Nameinstead ofName.Namespacefor tie-breaking when timestamps are equal - Updated documentation to clarify the sorting behavior for canary ingress resources
- Added comprehensive test case to verify canary ingress sorting behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/ingress/kube/common/tool.go | Changed sorting concatenation order from Name.Namespace to Namespace.Name and updated function documentation |
| pkg/ingress/kube/common/tool_test.go | Added test case to verify base ingress is sorted before canary variants with the same namespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
improve ingress sorting
Ⅱ. Does this pull request fix one issue?
fixes #3327
Ⅲ. Why don't you add test cases (unit test/integration test)?
yes
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Ⅵ. AI Coding Tool Usage Checklist (if applicable)
Please check all applicable items:
For new standalone features (e.g., new wasm plugin or golang-filter plugin):
design/directory in the plugin folderdesign/directoryFor regular updates/changes (not new plugins):
AI Coding Prompts (for regular updates)
AI Coding Summary