Skip to content

Conversation

@kylesezhi
Copy link
Contributor

@kylesezhi kylesezhi commented Sep 14, 2016

First attempt at adding Javascript rules from https://github.com/azu/technical-word-rules.

  1. Not sure how to add version number to "ECMAScript" in error message.
  2. Any feedback is appreciated.

I can finish the rest of the rules when I hear that my implementation looks good!

@kylesezhi
Copy link
Contributor Author

I am not sure why Travis CI is saying "no environment variables set". Also, I do not have permissions to see the Code Climate failures.

@joshmgrant
Copy link
Contributor

joshmgrant commented Sep 15, 2016

@kylesezhi If you click one one of those lines from Travis CI, you'll see the full terminal output from the Travis Job. In this case, your code failed some of the Python pep8 style guidelines,

Take a look at the terminal output and make fixes as needed. Definitely leave comments here if you need some help!

@kylesezhi
Copy link
Contributor Author

I think we are all clear on the pep8 now @joshmgrant but I am still not able to see my mistakes with Code Climate (permissions). Any suggestions?

@kylesezhi
Copy link
Contributor Author

Code Climate seems to think a list declaration is duplicated code - it is not, to my knowledge.

@joshmgrant
Copy link
Contributor

@kylesezhi I'm don't have permissions to see the Code Climate checks either. You'd have to ask @suchow about it. Your PR could still be merged at this point.

@kylesezhi
Copy link
Contributor Author

Thanks @joshmgrant! Other rules for CSS, etc from the original remain unimplemented here. I will continue pushing them as time permits!

@Nytelife26
Copy link
Contributor

This feels like it may become quite a noisy check. Either way, I'll triage this and we can discuss adding more technical language checks down the line.

@Nytelife26 Nytelife26 added the cat: new-check Extraction and implementation of, or a request for, a new check label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat: new-check Extraction and implementation of, or a request for, a new check type: feat A new feature

3 participants