-
Notifications
You must be signed in to change notification settings - Fork 180
Add technical language for JavaScript #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I am not sure why Travis CI is saying "no environment variables set". Also, I do not have permissions to see the Code Climate failures. |
|
@kylesezhi If you click one one of those lines from Travis CI, you'll see the full terminal output from the Travis Job. In this case, your code failed some of the Python pep8 style guidelines, Take a look at the terminal output and make fixes as needed. Definitely leave comments here if you need some help! |
|
I think we are all clear on the pep8 now @joshmgrant but I am still not able to see my mistakes with Code Climate (permissions). Any suggestions? |
|
Code Climate seems to think a list declaration is duplicated code - it is not, to my knowledge. |
|
@kylesezhi I'm don't have permissions to see the Code Climate checks either. You'd have to ask @suchow about it. Your PR could still be merged at this point. |
|
Thanks @joshmgrant! Other rules for CSS, etc from the original remain unimplemented here. I will continue pushing them as time permits! |
|
This feels like it may become quite a noisy check. Either way, I'll triage this and we can discuss adding more technical language checks down the line. |
First attempt at adding Javascript rules from https://github.com/azu/technical-word-rules.
I can finish the rest of the rules when I hear that my implementation looks good!