Conversation
Change-Id: Idf0ff3795174417ebfbe861a0f8cea3069927b4b
arriolac
left a comment
arriolac
left a comment
There was a problem hiding this comment.
LGTM just some minor comments
| // implementation(libs.androidx.compose.runtime.livedata) | ||
| // implementation(libs.androidx.compose.ui.tooling.preview) | ||
| // debugImplementation(libs.androidx.compose.ui.test.manifest) | ||
| // debugImplementation(libs.androidx.compose.ui.tooling) |
There was a problem hiding this comment.
Remove? Do you also want to add the dependencies to the .toml file or is that what the TODO is for?
There was a problem hiding this comment.
The todo is to remove the explicit dependencies and use these commented out versions again, once all Compose & Material3 dependencies align again
| * with | ||
| * @param openDrawer (event) request opening the app drawer | ||
| * @param scaffoldState (state) state for the [Scaffold] component on this screen | ||
| // * @param snackbarHostState (state) state for the [Scaffold] component on this screen |
| isExpandedScreen: Boolean, | ||
| openDrawer: () -> Unit, | ||
| scaffoldState: ScaffoldState = rememberScaffoldState() | ||
| snackbarHostState: SnackbarHostState = remember { SnackbarHostState() } |
There was a problem hiding this comment.
Should we have a rememberSnackbarHostState method defined? I see this pattern used elsewhere
There was a problem hiding this comment.
I don't know? It's not part of the public API, so I just used what's being used elsewhere. Something to discuss with @astamato maybe?
There was a problem hiding this comment.
Interesting, I'd leave as is for now. All the rememberX functions ive come across do smth more complex than just remember a single value.
* commit '5bc3451b11f9aae111b8a6dca0199a317c997a2b': (331 commits) Updating to safe flow collection with collectAsStateWithLifecycle() (android#970) [Jetsurvey] Converted to use Material 3 (android#954) [JetNews] Remove invalid comment (android#966) [Jetnews] Update to Material3 (android#964) Compose latest (android#961) Disable auto creation of deps PRs for renovate (android#960) Version Catalog support (android#950) Fixing: Remove Unused If-Else condition (android#884) [Jetcaster] Fix recomposition loop in verticalGradientScrim (android#946) Fix readme image size (android#926) Fix a11y bugs (android#914) Update Androidx Lifecycle deps to v2.5.1 (android#932) Update plugin com.android.test to v7.2.2 (android#931) [Crane] Fix destinations not in list issue. (android#938) Update main | Compose 1.2.1 | Compiler 1.3.0 | Kotlin 1.7.10 (android#924) Update accompanist_version to v0.25.1 added licence to shapes added shapes for material Added a fix to not show back button on permanent drawer, added Material shapes [All] Updating to Compose 1.2 (android#905) ...
3 participants
No description provided.