pendingReleaseCount leak in DefaultAudioSink (regression 1.8 -> 1.9) #3338

Version

Media3 1.10.1

More version details

Regression c8044ca (1.9.0); present 1.9.0→1.11.0-beta01 + main; clean in 1.8.0

Devices that reproduce the issue

device independent

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

1. Play any stream in the demo app
2. Go back to the stream list
3. check pendingReleaseCount in DefaultAudioSink

it looks like onReleased() is not called on the DefaultAudioSink and the counter doesn't decrement.

Expected result

pendingReleaseCount decrements to 0.

Actual result

pendingReleaseCount doesn't decrement.

if initializing an audio output fails, shouldWaitBeforeRetry() will stuck forever at "true", leading to a stalled playback.

Media

demo app streams

Bug Report

• You will email the zip file produced by adb bugreport to android-media-github@google.com after filing this issue.