Skip to content

Support file schemes in SimpleBitmapLoader #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonihei merged 2 commits into from
Aug 8, 2022
Merged

Support file schemes in SimpleBitmapLoader #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6016418
Support file schemes in SimpleBitmapLoader
tzugen Jul 6, 2022
8360235
Update JavaDoc accordingly
tzugen Jul 26, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions libraries/session/src/main/java/androidx/media3/session/SimpleBitmapLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,16 @@

/**
* A simple bitmap loader that delegates all tasks to an executor and supports fetching images from
* HTTP/HTTPS endpoints.
* {@code file} and {@code http}/{@code https} URIs.
*
* <p>Loading tasks are delegated to an {@link ExecutorService} (or {@link
* ListeningExecutorService}) defined during construction. If no executor service is defined, all
* tasks are delegated to a single-thread executor service that is shared between instances of this
* class.
*
* <p>The supported URI scheme is only HTTP/HTTPS and this class reads a resource only when the
* endpoint responds with an {@code HTTP 200} after sending the HTTP request.
* <p>The supported URIs schemes are {@code file} and {@code http}/{@code https}.
* For HTTP(S) transfers, this class reads a resource only when the endpoint responds
* with an {@code HTTP 200} after sending the HTTP request.
*/
@UnstableApi
public final class SimpleBitmapLoader implements BitmapLoader {
Expand Down Expand Up @@ -89,6 +90,9 @@ private static Bitmap decode(byte[] data) {
}

private static Bitmap load(Uri uri) throws IOException {
if (uri.getScheme().equals("file")) {
return BitmapFactory.decodeFile(uri.getPath());
}
URLConnection connection = new URL(uri.toString()).openConnection();
if (!(connection instanceof HttpURLConnection)) {
throw new UnsupportedOperationException("Unsupported scheme: " + uri.getScheme());
Expand Down