Skip to content

Fix ENCODING_DTS_UHD_P2 Issue#1299

Merged
copybara-service[bot] merged 2 commits intoandroidx:mainfrom
cedricxperi:encoding-dts-uhd-p2-issue
May 7, 2024
Merged

Fix ENCODING_DTS_UHD_P2 Issue#1299
copybara-service[bot] merged 2 commits intoandroidx:mainfrom
cedricxperi:encoding-dts-uhd-p2-issue

Conversation

@cedricxperi
Copy link
Copy Markdown
Contributor

During Direct Passthrough Audio Playback on platforms that supports AudioFormat.ENCODING_DTS_UHD_P2, we need to include C.ENCODING_DTS_UHD_P2 in DefaultAudioSink.getFramesPerEncodedSample() and DefaultAudioTrackBufferSizeProvider.getMaximumEncodedRateBytesPerSecond().

@cedricxperi
Copy link
Copy Markdown
Contributor Author

@microkatz Here is the new PR that merges into main branch. Thanks.

@microkatz microkatz self-assigned this Apr 22, 2024
@microkatz
Copy link
Copy Markdown
Contributor

@cedricxperi

Thanks for creating the new PR! One quick point, I think you may have missed a spot in the DefaultAudioTrackBufferSizeProvider.getPassthroughBufferSizeInBytes method? Would ENCODING_DTS_UHD_P2 need the same multiple for the buffersize computation for passthrough as ENCODING_DTS_HD?

@cedricxperi
Copy link
Copy Markdown
Contributor Author

@cedricxperi

Thanks for creating the new PR! One quick point, I think you may have missed a spot in the DefaultAudioTrackBufferSizeProvider.getPassthroughBufferSizeInBytes method? Would ENCODING_DTS_UHD_P2 need the same multiple for the buffersize computation for passthrough as ENCODING_DTS_HD?

@microkatz Thanks for pointing that out. However, DTS:X Profile 2 has a smaller number of audio samples per channel per frame compared to DTS-HD (DTS Express). So it does not require a bigger multiple for buffersize computation. :)

@microkatz microkatz force-pushed the encoding-dts-uhd-p2-issue branch from e010939 to 512eb55 Compare May 3, 2024 14:32
@microkatz
Copy link
Copy Markdown
Contributor

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!

@microkatz microkatz force-pushed the encoding-dts-uhd-p2-issue branch from 512eb55 to 6363017 Compare May 7, 2024 12:06
@copybara-service copybara-service bot merged commit 0969043 into androidx:main May 7, 2024
@androidx androidx locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants