Fix missing KEYCODE_HEADSETHOOK case#2779
Fix missing KEYCODE_HEADSETHOOK case#2779johngray1965 wants to merge 2 commits intoandroidx:releasefrom johngray1965:release
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…nnected_dispatchesEvent to include KEYCODE_MEDIA_PLAY_PAUSE & KEYCODE_HEADSETHOOK. Fixed a missing case for KEYCODE_HEADSETHOOK that caused the test above to fail.
…HOOK result in correct calls on the player
|
@marcbaechinger Could you please take a look at this PR to confirm whether it fixes the issue or not? |
|
@SURAJ2600 @marcbaechinger I've release a version of my app with a local build of media3 with this changes, and it resolved my issues. Please note that there's only 2 lines of change in the production code, and one of them is an import. |
|
Can you please create a new PR from the |
|
@marcbaechinger Sure, sorry I missed that it was from the wrong branch. I'll work on that now. |
|
This PR was on the wrong branch. #2779 replaces it. Closing this one. |
|
#2816 is one that replaces it. |
Fixes #2768