Skip to content

Fix missing KEYCODE_HEADSETHOOK case#2779

Closed
johngray1965 wants to merge 2 commits intoandroidx:releasefrom
johngray1965:release
Closed

Fix missing KEYCODE_HEADSETHOOK case#2779
johngray1965 wants to merge 2 commits intoandroidx:releasefrom
johngray1965:release

Conversation

@johngray1965
Copy link
Copy Markdown
Contributor

@johngray1965 johngray1965 commented Sep 15, 2025

Fixes #2768

@google-cla
Copy link
Copy Markdown

google-cla bot commented Sep 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…nnected_dispatchesEvent to include KEYCODE_MEDIA_PLAY_PAUSE & KEYCODE_HEADSETHOOK.

Fixed a missing case for KEYCODE_HEADSETHOOK that caused the test above to fail.
@johngray1965 johngray1965 changed the title Expanded onMediaButtonEvent_allSupportedKeys_notificationControllerCo… Sep 16, 2025
@SURAJ2600
Copy link
Copy Markdown

@marcbaechinger Could you please take a look at this PR to confirm whether it fixes the issue or not?
We’re still seeing the same problem on Samsung devices. I’ve tried several fixes, but the crash logs are still appearing in Telemetry.

@johngray1965
Copy link
Copy Markdown
Contributor Author

@SURAJ2600 @marcbaechinger I've release a version of my app with a local build of media3 with this changes, and it resolved my issues. Please note that there's only 2 lines of change in the production code, and one of them is an import.

@marcbaechinger
Copy link
Copy Markdown
Contributor

Can you please create a new PR from the main branch. The current PR is from the release branch. Sorry I haven't noticed this earlier.

@johngray1965
Copy link
Copy Markdown
Contributor Author

@marcbaechinger Sure, sorry I missed that it was from the wrong branch. I'll work on that now.

@johngray1965
Copy link
Copy Markdown
Contributor Author

This PR was on the wrong branch. #2779 replaces it. Closing this one.

@johngray1965
Copy link
Copy Markdown
Contributor Author

#2816 is one that replaces it.

@androidx androidx locked and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants