Skip to content

Add BROWSE intent for launching with exolist.json#439

Merged
tof-tof merged 2 commits intoandroidx:mainfrom
kaidokert:pick_workaround
Jun 7, 2023
Merged

Add BROWSE intent for launching with exolist.json#439
tof-tof merged 2 commits intoandroidx:mainfrom
kaidokert:pick_workaround

Conversation

@kaidokert
Copy link
Copy Markdown
Contributor

This works around the issue described in #438 by providing a fallback option to launch the app from adb shell.

Resolves #438

@marcbaechinger
Copy link
Copy Markdown
Contributor

marcbaechinger commented Jun 5, 2023

You'd have to do a pull request against the main branch, instead of the release branch. If you do so, can you use androidx.media3.demo.main.action.BROWSE? So we have a specific action for this that does never collide with another app supporting pick for json,

I can do this change internally myself also, if you want me.

@kaidokert kaidokert changed the base branch from release to main June 5, 2023 22:57
@kaidokert
Copy link
Copy Markdown
Contributor Author

kaidokert commented Jun 5, 2023

Updated !

EDIT: sorry nevermind i read you wrong, changing to androidx.media3.demo.main.action.BROWSE

@marcbaechinger marcbaechinger self-requested a review June 5, 2023 23:07
@marcbaechinger marcbaechinger self-assigned this Jun 5, 2023
@kaidokert kaidokert changed the title Add PICK intent for launching with exolist.json Jun 5, 2023
@marcbaechinger
Copy link
Copy Markdown
Contributor

Thanks!

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!

@tof-tof tof-tof merged commit 886717e into androidx:main Jun 7, 2023
tof-tof added a commit that referenced this pull request Jun 12, 2023
PiperOrigin-RevId: 538209925
(cherry picked from commit 886717e)
@androidx androidx locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants