Fix forward and rewind button texts cut off with material theme applied#914
Merged
copybara-service[bot] merged 2 commits intoandroidx:mainfrom Dec 21, 2023
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
marcbaechinger
force-pushed
the
366-forward-time-wrong
branch
from
fa69e5b to
793b27a
Compare
Contributor
|
I'm going to send this for internal review now. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
microkatz
pushed a commit
that referenced
this pull request
Jan 11, 2024
PiperOrigin-RevId: 592871532 (cherry picked from commit 966b517)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This style change does not affect the
Theme.AppCompat.NoActionBartheme applied to the demo app.You may test this patch by applying the
Theme.Material3.Darkas parent theme toPlayerThemeinsidedemos/main/src/main/res/values/styles.xml. The default 15 second forward text should not be cut off any longer.Tested on api levels 34 and 26.
Fixes #547