Remove dead code after minSdk was bump to 19#983
Merged
copybara-service[bot] merged 12 commits intoandroidx:mainfrom Feb 15, 2024
Merged
Remove dead code after minSdk was bump to 19#983copybara-service[bot] merged 12 commits intoandroidx:mainfrom
copybara-service[bot] merged 12 commits intoandroidx:mainfrom
Conversation
MGaetan89
commented
Jan 16, 2024
| import java.lang.reflect.Method; | ||
|
|
||
| /** Utilities for {@link Bundle}. */ | ||
| @UnstableApi |
Contributor
Author
There was a problem hiding this comment.
Since this class is marked as @UnstableApi, I think it's safe to delete it. If you prefer to deprecate it first, let me know, and I'll update my PR.
MGaetan89
force-pushed
the
min_api_19
branch
3 times, most recently
from
014dd08 to
4c3046e
Compare
Contributor
Author
|
I've fixed the conflict in |
Collaborator
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
MGaetan89
commented
Feb 8, 2024
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/AudioTimestampPoller.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/PlaceholderSurface.java
Outdated
Show resolved
Hide resolved
icbaker
approved these changes
Feb 9, 2024
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/AudioTimestampPoller.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/PlaceholderSurface.java
Outdated
Show resolved
Hide resolved
Also put back a comment in DownloadTracker that is still relevant on API 19. Also deprecate PlaceholderSurface.newInstanceV17() in favour of just newInstance()
…oller and CaptionStyleCompat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that this project supports API 19 and newer, some code could be simplified/removed, which is what this PR is about:
SDK_INTchecks@RequiresApi@TargetApi