Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(launcher): task promises run parallel#5406

Open
yadimon wants to merge 4 commits into
angular:masterfrom
yadimon:bugfix-max-instances
Open

fix(launcher): task promises run parallel#5406
yadimon wants to merge 4 commits into
angular:masterfrom
yadimon:bugfix-max-instances

Conversation

@yadimon

@yadimon yadimon commented Mar 11, 2020

Copy link
Copy Markdown

fix for #5145 + cosmetics

@IgorMinar don't know yet how to write tests for this. If you let me know the way, i could add them.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yadimon

yadimon commented Mar 11, 2020

Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@yadimon yadimon force-pushed the bugfix-max-instances branch from f02addf to e555ba8 Compare March 11, 2020 21:09
@yadimon yadimon changed the title Bugfix max instances Mar 11, 2020
@yadimon

yadimon commented Mar 13, 2020

Copy link
Copy Markdown
Author

added some kind of unit tests for this case, i hope its acceptable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2 participants