-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Build devel image and push to quay.io #16227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
|
@AlanCoding updated, now it re-use
|
|
AlanCoding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add a condition similar to this.
- name: Skipping build of awx image for non-awx repository
run: |
echo "Skipping build of awx image for non-awx repository"
exit 0
if: matrix.build-targets.image-name == 'awx' && !endsWith(github.repository, '/awx')This already exists in some other cases.
Why? Because https://quay.io/repository/aap/tower_devel is the objective here. But there is no https://quay.io/repository/aap/awx_devel, nor do we have a need for that, nor do we want that. In those cases, you want a public image, and use the ghcr awx_devel image that's already there.
To put it into words how this would be different - in your case you want to skip building the image for any non-tower repository. And maybe even more specific than that, probably needs to be specific to that 1 github org & repo.


SUMMARY
Fixes: https://issues.redhat.com/browse/AAP-61962
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
secrets.QUAY_TOKENandsecrets.QUAY_USER(thoughQUAY_USERmay not need to be a secret)develandstable-*branches)