AAP-63668 Harden log message output containing user input #16257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* base64 encode user inputed url when logging so that newlines or other malicious payloads can't be injected into the log stream
chrismeyersfsu
force-pushed
the
AAP-63668-webhook
branch
from
1d39e09 to
cead6f3
Compare
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chrismeyersfsu
force-pushed
the
AAP-63668-webhook
branch
from
8da3f8e to
9875af5
Compare
chrismeyersfsu
force-pushed
the
AAP-63668-webhook
branch
from
9875af5 to
6041b70
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/AAP-63668
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Note
Low Risk
Changes are limited to log formatting around redirects plus additional unit coverage; runtime behavior for sending requests is unchanged aside from the logged message content.
Overview
Hardens webhook redirect logging by base64-encoding the current and next redirect URLs before emitting warning/error messages, reducing the risk of log injection from user-supplied URLs.
Adds unit tests covering redirect-follow behavior (successful redirect chain, missing
Locationheader, and max-retry exhaustion) and ensures non-2xx responses (e.g., 404) are logged and treated as send failures whenfail_silentlyis enabled.Written by Cursor Bugbot for commit 6041b70. This will update automatically on new commits. Configure here.