fix version check #61318
Draft
fix version check #61318
+10,627
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:common-compat
provider:edge
Contributor
Author
…4/airflow into Fix_version_check_#61313
Contributor
|
(1) the package-lock.json should not be committed. You can setup your devenv as described in https://github.com/apache/airflow/blob/main/contributing-docs/03a_contributors_quick_start_beginners.rst and with prek the static assets are locally re-generated including the needed www-hash.txt (2) Please check the PR template banner and use the template (3) I assume the fix is not working by reading the code. Please check with the commands given in the issue title included if it really fixes. I do not see how a pre-release suffix shall be cut and frankly speaking the fix looks like AI slop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix version check for EdgeExecutor UI with release candidatesChanged how Airflow version comparison works in the EdgeExecutor plugin to properly handle versions like "3.1.7rc1". The issue was that release candidate versions weren't being recognized correctly, causing the UI to fail. Now both "3.1.7rc1" and "3.1.7" work the same way for version checks.
Used AI for resolving conflicts