Skip to content

server: make some settings slidable - #13749

Open
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-fix-setting-slidable
Open

server: make some settings slidable#13749
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-fix-setting-slidable

Conversation

@weizhouapache

@weizhouapache weizhouapache commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes some global settings which are not slidable.

for example

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.69%. Comparing base (0339f31) to head (481ccbb).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13749      +/-   ##
============================================
- Coverage     17.69%   17.69%   -0.01%     
+ Complexity    15833    15832       -1     
============================================
  Files          5925     5926       +1     
  Lines        533534   533537       +3     
  Branches      65273    65273              
============================================
  Hits          94421    94421              
- Misses       428434   428440       +6     
+ Partials      10679    10676       -3     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GaOrtiga GaOrtiga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18716

@weizhouapache

Copy link
Copy Markdown
Member Author
@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16661)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54725 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13749-t16661-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment