Skip to content

introduce explaining variable refactoring.#170

Open
Vivek504 wants to merge 1 commit into
apache:trunkfrom
Vivek504:introduce-explaining-variable-refactoring
Open

introduce explaining variable refactoring.#170
Vivek504 wants to merge 1 commit into
apache:trunkfrom
Vivek504:introduce-explaining-variable-refactoring

Conversation

@Vivek504

Copy link
Copy Markdown

Introduce Explaining Variable Refactoring

Reason: Long Statement

  1. The length of the statement "final MethodHandle nonNullTest=lookup.findStatic(Objects.class,"nonNull",methodType(boolean.class,Object.class)).asType(methodType(boolean.class,cleanerClass));" is 160.
  2. The length of the statement "final MethodHandle unmapper=filterReturnValue(directBufferCleanerMethod,guardWithTest(nonNullTest,cleanMethod,noop)).asType(methodType(void.class,ByteBuffer.class));" is 165.

Logic of the refactoring: Complicated expressions are replaced by explaining variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant