fix: clone Parameters before mutation in security and validator providers#8378
Open
ostrolucky wants to merge 1 commit into
Open
fix: clone Parameters before mutation in security and validator providers#8378ostrolucky wants to merge 1 commit into
ostrolucky wants to merge 1 commit into
Conversation
…ders SecurityParameterProvider and ParameterValidatorProvider both called $parameters->add() on the Parameters object returned directly from the cached operation, mutating shared state. In long-running processes (Behat/FrankenPHP/RoadRunner) this caused uri-variable Links added at request time to leak into subsequent metadata reads, producing a phantom in:query parameter in the OpenAPI output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling $parameters->add() on the Parameters object was mutating shared state. In long-running processes this caused uri-variable Links added at request time to leak into subsequent metadata reads, producing a phantom in:query parameter in the OpenAPI output in my case, resulting most obviously in flaky tests in my case