Skip to content

feat: add_requests and enqueue_links context helpers#120

Merged
janbuchar merged 21 commits into
masterfrom
enqueue-links
Apr 30, 2024
Merged

feat: add_requests and enqueue_links context helpers#120
janbuchar merged 21 commits into
masterfrom
enqueue-links

Conversation

@janbuchar

@janbuchar janbuchar commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator
@janbuchar janbuchar requested a review from vdusek April 18, 2024 13:21
@github-actions github-actions Bot added this to the 87th sprint - Tooling team milestone Apr 18, 2024
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 18, 2024

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Apr 19, 2024

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek removed their request for review April 22, 2024 16:48
@janbuchar janbuchar marked this pull request as ready for review April 23, 2024 13:12
@vdusek vdusek self-requested a review April 23, 2024 13:38
Comment thread src/crawlee/request.py Outdated
Comment thread src/crawlee/basic_crawler/basic_crawler.py Outdated
Comment thread src/crawlee/basic_crawler/basic_crawler.py Outdated
Comment thread src/crawlee/basic_crawler/basic_crawler.py Outdated
Comment thread src/crawlee/enqueue_strategy.py
Comment thread src/crawlee/globs.py
Comment thread src/crawlee/basic_crawler/types.py
Comment thread src/crawlee/basic_crawler/basic_crawler.py
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@vdusek vdusek self-requested a review April 29, 2024 09:40

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more comments, otherwise it's great, thanks.

Comment thread src/crawlee/basic_crawler/basic_crawler.py
Comment thread src/crawlee/basic_crawler/basic_crawler.py

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar merged commit dc850a5 into master Apr 30, 2024
@janbuchar janbuchar deleted the enqueue-links branch April 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

4 participants