feat: use SessionPool in BasicCrawler#128
Merged
Merged
Conversation
github-actions
Bot
added
t-tooling
janbuchar
force-pushed
the
use-session-pool-in-basic-crawler
branch
from
27403d4 to
0229ad8
Compare
vdusek
reviewed
May 2, 2024
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just a few questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes Integrate
SessionPoolintoBasicCrawler#110BasicCrawlernow usesSessionPoolto fill in a session into the crawling contextthere is a separate retry mechanism for session errors (when we get blocked)
cookies from HTTP responses are persisted in the respective sessions