Skip to content

fix: Reset all counter in metadata with purge for RequestQueue#1686

Merged
vdusek merged 1 commit into
apify:masterfrom
Mantisus:fix-rq-porge
Jan 26, 2026
Merged

fix: Reset all counter in metadata with purge for RequestQueue#1686
vdusek merged 1 commit into
apify:masterfrom
Mantisus:fix-rq-porge

Conversation

@Mantisus

Copy link
Copy Markdown
Collaborator

Description

  • Reset all counter in metadata with purge for RequestQueue. This will be more consistent with JS. Also, saving the total_request_count and handled_request_count counters causes confusion among users, especially when this happens with the default queue.

Issues

@Mantisus Mantisus requested review from Pijukatel and vdusek January 24, 2026 20:36
@Mantisus Mantisus self-assigned this Jan 24, 2026
@Mantisus

Copy link
Copy Markdown
Collaborator Author

@vdusek The current behavior of purge was implemented during the storage refactoring. Perhaps there was a reason for keeping the handled_request_count' and total_request_count' counters?

@vdusek

vdusek commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Yeah, I initially thought total_request_count should represent the actual total number of requests this instance has processed (even if purge was executed), with only a drop resetting it. But if that's confusing or inconsistent with the JS version, then let's change it.

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vdusek vdusek merged commit ee09260 into apify:master Jan 26, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants