fix: Keep None values for user_data in Request#1707
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Request class where None values in the user_data field were being excluded during serialization. The change ensures that explicit None values are preserved by setting exclude_none=False in the serialization configuration.
Changes:
- Modified the
user_dataserialization behavior to retain explicitNonevalues
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mantisus
force-pushed
the
keep-none-user-data
branch
from
4a56bff to
83614f7
Compare
| lambda instance: user_data_adapter.dump_python( | ||
| instance, | ||
| by_alias=True, | ||
| exclude_none=True, |
There was a problem hiding this comment.
@janbuchar do you remember if this had any specific reason?
There was a problem hiding this comment.
No, I don't. The new behavior seems more explicit and I can't think of a problem that I could cause, so let's do this
There was a problem hiding this comment.
No, I don't. The new behavior seems more explicit and I can't think of a problem that I could cause, so let's do this
### Description - This PR fixes loss of `None` values in `user_data` during `Request` serialization ### Issues - Closes: apify#1706
Description
Nonevalues inuser_dataduringRequestserializationIssues