fix: retry sitemap fetching on error and raise when retries are exhausted#1943
Merged
Conversation
…sted The try/except in _fetch_and_process_sitemap wrapped the whole retry loop instead of its body, so any fetch error exited the loop after a single attempt and was silently swallowed, leaving callers with empty or partial results. Each attempt is now independently retried and the error is raised once all retries are exhausted.
vdusek
added
t-tooling
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1943 +/- ##
==========================================
+ Coverage 92.92% 93.03% +0.10%
==========================================
Files 167 167
Lines 11710 11712 +2
==========================================
+ Hits 10882 10896 +14
+ Misses 828 816 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
janbuchar
approved these changes
Jun 4, 2026
…etries # Conflicts: # tests/unit/_utils/test_sitemap.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
try/exceptin_fetch_and_process_sitemapwrapped the entirewhile retries_left > 0loop instead of the loop body. Any exception raised while streaming a sitemap therefore exited the loop after a single attempt, logged a warning, and silently ended the async generator — no retry ever happened,sitemap_retrieswas effectively dead code, and callers (Sitemap.load,parse_sitemap,SitemapRequestLoader) saw empty or partial results with no error.This PR moves the
try/exceptinside the loop body so each attempt is independently retried, and raises the error once all retries are exhausted instead of swallowing it.Behavior notes
SitemapRequestLoaderalready logs and propagates this via its own error handling.