fix: Gracefully close sitemap stream on SitemapRequestLoader abort#1979
Merged
Conversation
vdusek
reviewed
Jun 19, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Isn't this just a non-optimal workaround? 🙂
CC suggests utilizing this pattern:
from contextlib import aclosing, suppress # already importing suppress here
# in _load_sitemaps, replace the bare `async for item in parse_sitemap(...)`:
async with aclosing(
parse_sitemap(
[SitemapSource(type='url', url=sitemap_url)],
self._http_client,
proxy_info=self._proxy_info,
options=parse_options,
)
) as sitemap_items:
async for item in sitemap_items:
...
Collaborator
Author
|
Well, |
Pijukatel
approved these changes
Jun 22, 2026
Mantisus
added a commit
to Mantisus/crawlee-python
that referenced
this pull request
Jun 30, 2026
…pify#1979) ### Description Use `contextlib.aclosing` to let the stream request finishes gracefully and avoids errors when closing generators. Example error: ```bash an error occurred during closing of asynchronous generator <async_generator object HttpxHttpClient.stream at 0x7bad2c3fbe10> asyncgen: <async_generator object HttpxHttpClient.stream at 0x7bad2c3fbe10> RuntimeError: aclose(): asynchronous generator is already running ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
contextlib.aclosingto let thestream request finishes gracefully and avoids errors when closing generators.
Example error: