feat: Project templates#237
Conversation
janbuchar
added
the
t-tooling
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
None of the pull request and linked issue has estimate
| playwright = ["playwright"] | ||
|
|
||
| [tool.poetry.scripts] | ||
| crawlee = "crawlee.cli:cli" |
There was a problem hiding this comment.
This should enable us to do pipx run crawlee create once this hits PyPI
| inquirer.List( | ||
| 'template', | ||
| message='Please select the template for your new Crawlee project', | ||
| choices=[(choice[0].upper() + choice[1:], choice) for choice in template_choices], |
There was a problem hiding this comment.
This is not as pretty as a handwritten description, but we don't have to maintain a manifest. It sounds like an OK tradeoff to me, but I'm willing to discuss this.
| inquirer.Text( | ||
| 'project_name', | ||
| message='Name of the new project folder', | ||
| validate=lambda _, it: len(it) > 0, |
There was a problem hiding this comment.
This prevents us from using the defaults in cookiecutter.json. Not sure if that's a problem.
|
This is still pretty barebones (see my comments), but I'd prefer to get the CLI to PyPI as quickly as possible and iterate upon that. |
janbuchar
force-pushed
the
project-templates
branch
from
e8014d0 to
85c774f
Compare
B4nan
left a comment
B4nan
left a comment
There was a problem hiding this comment.
gave this a quick look and i would merge it asap, better have some templates than no templates at all, we can improve over time
2 participants
to test this:
or even better (the
--spec ...part won't be necessary after merge)