Skip to content

fix: project bootstrapping in existing folder#318

Merged
janbuchar merged 4 commits into
masterfrom
fix-project-bootstrapping-in-existing-folder
Jul 18, 2024
Merged

fix: project bootstrapping in existing folder#318
janbuchar merged 4 commits into
masterfrom
fix-project-bootstrapping-in-existing-folder

Conversation

@janbuchar

Copy link
Copy Markdown
Collaborator

Typer bit me quite hard here, but we should be out of the dark now.

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 17, 2024
@janbuchar janbuchar requested review from B4nan and vdusek July 17, 2024 12:54
@github-actions github-actions Bot added this to the 94th sprint - Tooling team milestone Jul 17, 2024

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was written originally in a rush, just before the launch - but could we have some tests now?

I just quickly checked the docs https://typer.tiangolo.com/tutorial/testing/ and it shouldn't be a problem.

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, it works great. Just the tests please.

Edit: please do not forget to add a record to the changelog as well

@B4nan B4nan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i'll test it once released and published as beta

@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jul 18, 2024
@janbuchar janbuchar merged commit c630818 into master Jul 18, 2024
@janbuchar janbuchar deleted the fix-project-bootstrapping-in-existing-folder branch July 18, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

3 participants