Skip to content

fix: Warn instead of crashing when an empty dataset is being exported#342

Merged
janbuchar merged 1 commit into
masterfrom
fix-crash-on-empty-dataset-export
Jul 24, 2024
Merged

fix: Warn instead of crashing when an empty dataset is being exported#342
janbuchar merged 1 commit into
masterfrom
fix-crash-on-empty-dataset-export

Conversation

@janbuchar

@janbuchar janbuchar commented Jul 22, 2024

Copy link
Copy Markdown
Collaborator
@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 22, 2024
@janbuchar janbuchar requested a review from vdusek July 22, 2024 16:25
@github-actions github-actions Bot added this to the 94th sprint - Tooling team milestone Jul 22, 2024
vdusek
vdusek approved these changes Jul 24, 2024
View reviewed changes

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe just changelog? depends on #330
@janbuchar

janbuchar commented Jul 24, 2024

Copy link
Copy Markdown
Collaborator Author

I think that's redundant at this point, #330 should be ready for testing now.
@janbuchar janbuchar merged commit 22b95d1 into master Jul 24, 2024
@janbuchar janbuchar deleted the fix-crash-on-empty-dataset-export branch July 24, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

2 participants

@janbuchar @vdusek