Skip to content

fix: double incrementation of item_count#443

Merged
vdusek merged 2 commits into
apify:masterfrom
cadlagtrader:metadata_storage_not_purged
Aug 30, 2024
Merged

fix: double incrementation of item_count#443
vdusek merged 2 commits into
apify:masterfrom
cadlagtrader:metadata_storage_not_purged

Conversation

@cadlagtrader

@cadlagtrader cadlagtrader commented Aug 19, 2024 •
edited by vdusek
Loading

Copy link
Copy Markdown
Contributor

Description

  • item_count unexpected increment when loaded from metadata

Issues

Testing

  • Added test_reuse_dataset test

Checklist

  • CI passed
@cadlagtrader cadlagtrader mentioned this pull request Aug 19, 2024
Closed
@cadlagtrader cadlagtrader changed the title fix item_count double incremented Aug 19, 2024
@vdusek vdusek self-requested a review August 20, 2024 12:31
vdusek
vdusek requested changes Aug 20, 2024
View reviewed changes
Comment thread tests/unit/memory_storage_client/test_dataset_client.py
@fnesveda fnesveda added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 21, 2024
vdusek
vdusek approved these changes Aug 30, 2024
View reviewed changes

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@vdusek vdusek changed the title fix: item_count double incremented Aug 30, 2024
@vdusek vdusek merged commit cd9adf1 into apify:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

3 participants

@cadlagtrader @vdusek @fnesveda