feat: implement BasicCrawler#56
Merged
Merged
Conversation
github-actions
Bot
added
t-tooling
janbuchar
force-pushed
the
basic-crawler
branch
from
ef31d2b to
1bd0e09
Compare
janbuchar
force-pushed
the
basic-crawler
branch
from
905902e to
8cc7fba
Compare
janbuchar
force-pushed
the
basic-crawler
branch
from
930e585 to
1631ba1
Compare
janbuchar
force-pushed
the
basic-crawler
branch
from
e8d45de to
5eb18ff
Compare
janbuchar
commented
Apr 5, 2024
vdusek
requested changes
Apr 9, 2024
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Quite a lot of comments, however, a lot of them should be easy fixes. Great job otherwise!
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
vdusek
requested changes
Apr 9, 2024
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Member
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasicCrawler#30