feat: Added get_public_url method to KeyValueStore

[akshay11298]

Description

• Implement get_public_url method in KeyValueStore

Issues

• Closes: Implement KeyValueStore.get_public_url #514

Testing

• Unit tests added

Checklist

• CI passed

[janbuchar]

This looks like the right approach. You should use the storage_dir attribute of the configuration object instead of the current directory though.

[akshay11298]

This looks like the right approach. You should use the storage_dir attribute of the configuration object instead of the current directory though.

@janbuchar Thanks for the review and hint :) I have updated the PR with storage_dir

[janbuchar]

@akshay11298 sorry for the broken CI. I confirm that code quality checks are passing on my machine.

[akshay11298]

@janbuchar @vdusek found the cause of the error. It was the slash used when creating the path manually. Used os.path.join to fix the error

Edit:
Just saw the build result, the test is not able to read the file. Its giving permission denied error. Although I am wondering if this was created by the application, ideally it should have the access as well. I will be checking this. Although any idea on why it may occur though?

[akshay11298]

@janbuchar @vdusek Now the test passes. urlparse was returning netloc in windows and path in mac/linux

Windows -

Mac -

[vdusek]

Thanks, @akshay11298, for solving it. I added one more test, test_get_public_url_raises_for_non_existing_key, and updated the method a bit so that it passes. LGTM.

[janbuchar]

LGTM

[janbuchar]

LGTM