Skip to content

fix: restore proxy functionality for PlaywrightCrawler broken in v0.5#889

Merged
vdusek merged 3 commits into
apify:masterfrom
Mantisus:fix-playwright-proxy
Jan 15, 2025
Merged

fix: restore proxy functionality for PlaywrightCrawler broken in v0.5#889
vdusek merged 3 commits into
apify:masterfrom
Mantisus:fix-playwright-proxy

Conversation

@Mantisus

@Mantisus Mantisus commented Jan 9, 2025

Copy link
Copy Markdown
Collaborator

Description

  • fix for proxy in PlaywrightCrawler

Issues

Testing

  • Added test to verify proxy is correctly set for PlaywrightCrawler
@Mantisus Mantisus self-assigned this Jan 9, 2025
@B4nan B4nan changed the title fix: restore proxy functionality for PlaywrightCrawler broken in 5.0 Jan 9, 2025
@janbuchar janbuchar requested review from Pijukatel and vdusek and removed request for Pijukatel January 9, 2025 16:28
Comment thread tests/unit/crawlers/_playwright/test_playwright_crawler.py
@Mantisus Mantisus requested a review from vdusek January 10, 2025 08:54

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 908c944 into apify:master Jan 15, 2025
@vdusek vdusek added this to the 106th sprint - Tooling team milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants