refactor!: change Session cookies from dict to SessionCookies with CookieJar#984
Merged
Conversation
Pijukatel
reviewed
Feb 14, 2025
vdusek
requested changes
Feb 19, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Since it contains a breaking change, could you please describe the breaking changes in the PR's description and also summarize it in the Upgrading guide?
Pijukatel
reviewed
Feb 19, 2025
vdusek
reviewed
Feb 20, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
There are failing tests for Windows Python 3.12.
Mantisus
force-pushed
the
session-with-cookiejar
branch
from
003faf8 to
f136bcd
Compare
Collaborator
Author
The problem is not related to this PR. It's solved in the PR #1007 |
Pijukatel
previously approved these changes
Feb 21, 2025
vdusek
requested changes
Feb 24, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just a few minor comments and one concern regarding the usage of HTTPX's cookies.
Pijukatel
reviewed
Feb 25, 2025
vdusek
reviewed
Feb 25, 2025
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Pijukatel
approved these changes
Feb 25, 2025
vdusek
approved these changes
Feb 25, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM and great job, just wait for the resolution of the last unresolved conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SessionfromdicttoSessionCookieswhich usesCookieJar. It supports basic cookie parameters and multiple domains.Issues
Testing