Add flag to turn power assertions on/off #1419
Open
+278
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HT154
reviewed
Jan 30, 2026
| names = arrayOf("--power-assertions"), | ||
| help = "Enable power assertions for detailed assertion failure messages.", | ||
| ) | ||
| .flag() |
Contributor
There was a problem hiding this comment.
To ease copy/paste of options between test and eval commands, it might be nice to also support --no-power-assertions here
Suggested change
| .flag() | |
| .flag("--no-power-assertions", default = false, defaultForHelp = "disabled") |
| return holder.traceMode; | ||
| } | ||
|
|
||
| public boolean getPowerAssertions() { |
Contributor
There was a problem hiding this comment.
Nit: naming?
Suggested change
| public boolean getPowerAssertions() { | |
| public boolean getPowerAssertionsEnabled() { |
Contributor
|
Don't we better figure out why the performance drops and fix it? 🤔 |
Contributor
Natch. We understand why it happens and are looking into how to best resolve it. Either way, I think it's still valuable to have an option for this so that users with large test suites can disable power assertions for a performance boost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Power assertions have a big impact in the runtime performance of Pkl (~2x). This is negligible in most scenarios, but in some cases the performance lost is unacceptable.
This PR adds a flag to
pkl evalandpkl test:--power-assertions.This flag is enabled by default for
pkl testand disabled by default forpkl eval.Users can decide by themselves if they want it or not.