Skip to content

chore: disallow relative imports #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bchampp wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: disallow relative imports #8403

bchampp wants to merge 1 commit into from

Conversation

@bchampp
Copy link
Member

@bchampp bchampp commented Nov 5, 2025 •
edited
Loading

Which issue(s) does this change fix?

Why is this change necessary?

Updating the linting configuration in SAM CLI to disallow relative imports.

How does it address the issue?

Adding updated rules in the linting configuration in pyproject.toml to disallow relative imports. Updating all instances of relative imports to absolute for make pr to pass.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@bchampp bchampp requested a review from a team as a code owner November 5, 2025 04:00
@github-actions github-actions bot added area/local/start-api sam local start-api command area/init sam init area/local/invoke sam local invoke command area/pipeline area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 5, 2025
@bchampp bchampp marked this pull request as draft December 3, 2025 06:46
@bchampp bchampp force-pushed the tmp-disallow-relative-imports branch 2 times, most recently from d4f4d3e to 5224e68 Compare January 30, 2026 18:37
@bchampp bchampp force-pushed the tmp-disallow-relative-imports branch from 5224e68 to da61683 Compare January 30, 2026 18:42
@bchampp bchampp marked this pull request as ready for review January 30, 2026 19:02
vicheey
vicheey approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@vicheey vicheey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/init sam init area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/pipeline pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

2 participants

@bchampp @vicheey