feat: allow calling RunBazelisk with custom stderr - #751
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom stderr handling in Bazelisk's Go library API, allowing library consumers to redirect stderr output to custom writers instead of always using the process's stderr. This enhancement improves the flexibility of Bazelisk when used as a library.
Changes:
- Added new public API function
RunBazeliskWithArgsFuncAndConfigAndOutAndErrthat accepts both stdout and stderr writers - Updated internal functions
makeBazelCmdandrunBazelto accept and handle custom stderr writers - Maintained backward compatibility by having existing functions delegate to the new function with
nilfor stderr
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sitaktif
force-pushed
the
runbazelisk-stderr-param
branch
from
January 22, 2026 16:13
87efb87 to
a7e8e96
Compare
sitaktif
force-pushed
the
runbazelisk-stderr-param
branch
from
January 23, 2026 09:43
a7e8e96 to
1e6aafa
Compare
fweikert
approved these changes
Jan 23, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows library users to control what happens with stderr (e.g. write it to a file or buffer instead of the process' stderr).