Overload connect function to accept binary host - #906
Merged
Conversation
A -spec between the two connect/4 clauses split them into separate function definitions, causing redefinition errors. Combine the binary Host clause with the existing one and widen the spec to string() | binary().
Owner
|
Thanks @TBK145 for restoring this. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was present in 1.* versions: https://github.com/benoitc/hackney/blob/1.25.0/src/hackney_connect.erl#L29-L30
It breaks some of our dependencies, so I added it back in the main hackney.erl