-
Notifications
You must be signed in to change notification settings - Fork 137
Fix typo in the Awaiting documentation #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_secondes -> wait_seconds
Owner
|
Thanks |
coffeebeats
added a commit
to coffeebeats/gut
that referenced
this pull request
Nov 28, 2025
* include parameter list in passing test message (bitwes#698) * fixed issue (bitwes#699) * Refactor wait methods (bitwes#701) * deprecate wait_frames, add wait_idle_frames, wait_physics_frames * refactor tests to use wait_physics_frames * rename wait_idle_frames to wait_process_frames * change when frames are counted to SceneTree signals * it got lazy and did not test wait_idle_frames alias * CHANGES * documentation * I630 wait while (bitwes#703) * add wait_while` * CHANGES * Add instructions for installing gut as a git submodule (bitwes#695) * fixed typo in documentation README * instruction for adding gut as git submodule * Wrap failure and pending messages with CDATA (bitwes#707) * Wrap skipped and failure messages in CDATA * added tests to repliate tags in output --------- Co-authored-by: Ali Wallick <awallick@seconddinner.com> * fixed optparse unittest (bitwes#704) test mistakenly taking no argument instead of an empty list as an argument to signify no passed arguments * add hold_frams and hold_seconds to input sender (bitwes#712) * version bump * Clear embedded font from OutputText.tscn (bitwes#713) * Optparse option aliases (bitwes#705) * added aliases for optparse nonpositional arguments * Added a manual alias --script for cmdline option -s * added tests for optparse aliases. added test for using --script instead of -s. * updated optparse option to_s to print out aliases * updated unit tests for optparse Option.to_s to ensure correct alias printing * moved responsibility for adding aliases to Option instance from OptParse to Options and updated tests accordingly * replaced Array.find_custom() with Array.map().find() for godot 4.3 compatibility. * formatting * changed optparse interface to accept aliases and argument names in the same list * added type hinting for user facing functions and docstrings * removed old comment * updated docstrings * regenerated docs * Fix typo in the Awaiting documentation (bitwes#714) wait_secondes -> wait_seconds * Avoid global `Logger` as this conflicts with a native class in Godot 4.5 (bitwes#715) Fixes bitwes#709 ERROR: res://addons/gut/utils.gd:95 - Parse Error: The member "Logger" shadows a native class. * Pass signals instead of strings (bitwes#717) * accept signals as parameters * refactor and documentation * 9.4.0 documentation changes (bitwes#720) * documentation * Update README.md Update Godot Version * Check if object emitting signal exist before disconnecting (bitwes#726) * Check if object emitting signal exist before disconnecting If object emitting the signal was freed immediately after emitting the signal, Godot logged internal error. * Use is_instance_valid instead of null comparison * updated readme (bitwes#727) * Godot 4 4 (bitwes#728) * uid and fix str tests * Godot 4.4.1 * fix count display in editor * more uid files * ready to merge into main * I 725 (bitwes#729) * class_name dictionary * extra output test changes * fix a bug in OneToMany * Update README.md Add Godot 4.5 version link * Update README.md * fix: register_inner_classes can handle cyclic dependencies (bitwes#750) * fix: register_inner_classes can handle cyclic dependencies * refactor: _register_inners ignores constants instead of checking _registry for duplicates * feat(inner_class_registry): add tests for cyclic references * Godot 4 5 (bitwes#760) * skip vararg methods, remove gdc test files * tweaks * more test/illustration of vararg issue * oops * Godot 4 5 vararg (bitwes#734) * varargs can be doubled and stubbed * removed parameter count stubbing * cleanup * rename is_param_override_only * more clean up * Godot 4 5 error hook (bitwes#737) * proof of concept works * fix a bug in OneToMany * use existing logger to detect godot errors * poc proofed * test handling errors * error tracker complete * change tracker defaults * integrated into gut * adjust tests for new error mechanism * moved internal test tools * rename more internal stuff * add option to config, deprecate old option * add flags to gui * remove old gut flag * allow disabling of error tracking * remove logging * remove GutUtils._test_mode * wiki page * GutTest error asserts and tools * documentation * fix tests, documentation, adjust doc generation * clear errors after each parameterized test run * fix moved constants * expected error discalimer, assert error text * parameterized tests are taking a smidge longer * use new code in internal tests more * documentation * code review * Min await message time (bitwes#738) * min delay implemented * adding option * rename option * CHANGES, refactor, gui option * Godot 4 5 better orphans (bitwes#739) * logging orphan ids is way better * display orphan nodes in the tree control * documentation * code review * methods now just return if __gut_dbl is null * Godot 4 5 better orphan assert output (bitwes#741) * Better * ever better still * not better, but less commented out code...which is better * some cleanup * more better * move final orphan output after hook script * Godot 4 5 menu shortcuts (bitwes#742) * new menu working * all shortcuts functional * refactor shortcuts dialog * as good as it gets for now * remove the old way * Godot 4 5 shell out (bitwes#743) * it can happen * it can happen * prettier, runs better, fully integrated * more integration, remember dialog sizes * refactor/rename * refactor panel/external gui * validate arguments * tweak it * threaded non-blocking stdio/stderr reading * thread works * move button * it works * some settings, some tweaks, some prefs * icons, pop out button * changes * fix an icon issue appearing in beta 6 * code review * Godot 4 5 about (bitwes#744) * dialog looking ok * final about touches * CHANGES * no more editor orphans * there is now a blurb printed for before_all/after_all failures (bitwes#747) * font loading/serving system implemented (bitwes#751) * font loading/serving system implemented * code review * Better editor tracking (bitwes#753) * new notifier created and integrated * removed old way, made adjustments, works great, i think * CHANGES * Godot 4 5 tweaks (bitwes#755) * remove extra window/dock button on window * show_gut menu item, some tweaks * dynamic menu dupe, show_hide copied the project menu in an absurd way. menus got out of control, but it works and now shortcuts work everywhere * leaked SceneTreeTimer in tests * some documentation * maybe stopped a leak? * better handling of shortcuts * added THE WARNING and fixed a parsing bug * better warning * Godot 4 5 tweaks 2 (bitwes#757) * Update README.md * better secondary test script check * some button arrangements and totals display * tree improvements * vert layout in window, limit warnings to 5 * version bump * documentation * display cli help in output panel * wrap cli help text * word wrap on gui * some export fixes * ignore exit flags in GutControl * some demo video issues * dynamically get EditorInterface * less dynamic EditorInterface retrieval. * changes and documentation * readme links * fix error calling get_base_script on null instance for non-script files (bitwes#765) Perfect, thanks. * Add abstract class/method support (bitwes#763) * Add abstract class/method support * Simplify abstract parent check * Extend abstract parent check to cover all stub scenarios * Replace with simpler implementation * Add regression test for get_script_method_list() order * Fix script_parser script method processing + error message assert * Improve assert in abstract class double test * Revert unrelated changes * Docstrings and type hints for junit_xml_export and strutils (bitwes#711) * resolving conflict in documentation rst * removed private docstrings * made one more method private and regenerated docs * I775 push warning (bitwes#778) * error tracking handles warnings * new and updated asserts assert_push_warning_count, assert_push_warning, assert_engine_error_count, assert_push_error_count * documentation * changes and docs * code review * regenerate documentation * Track Test's Elapsed Time (bitwes#769) * added methods to track elapsed time of test method and assert against it * added unit tests to test new assert_time_elapsed methods * removed elapsed time assertions and added elapsed idle and physics frame tracking * Changed process/physics frame counting to use Engine.get_{physics,process}_frames(). Made get_elapsed_idle_frames alias for get_elapsed_process_frames. * Changed GutTest elapsed time methods to use Time.get_ticks_{m,u}sec instead of Time.get_unix_time_from_system * Added reset_start_time method to make setting time stats variables simpler * rebuilt docs * Singleton doubling (bitwes#782) * creating empty double of singletons * stubbing methods on singleton doubles * partial singleton doubles * test.gd methods * example using time * refactoring\ * everything passing * another classdb class that does not exist * clean up * move class name/ref hash * refined class name/ref hash population * stub params locking * documentation * refactor singlton data to generated script * using instance_id of singleton * var rename, use get_singleton * lazy load class dictionary * regenerate godot_singletons * native call super fixed issue where native methods were not effectively being called to call super by default * fix leaks, headless handling Fix some instance leaks caused by new stubs class. Added logic to exit and ignore pauses when running headless * code review * CHANGES.md * implmented bitwes#780 fix (bitwes#784) * wiki index entries, version bump --------- Co-authored-by: Butch Wesley <butch.wesley@gmail.com> Co-authored-by: Curtis Barnhart <98676521+Curtis-Barnhart@users.noreply.github.com> Co-authored-by: Ali Wallick <awallick@seconddinner.com> Co-authored-by: Greg Brock <contact@gbrock.com> Co-authored-by: Pablo Fernandez <pablo@pablofernandez.tech> Co-authored-by: Dave Reed <dreed@seconddinner.com> Co-authored-by: Maciej Radzikowski <maciej@radzikowski.com.pl> Co-authored-by: thephilipquan <100551718+thephilipquan@users.noreply.github.com> Co-authored-by: Fabian Donner <ThunderFD@users.noreply.github.com> Co-authored-by: Simon Kerler <namelessvoid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_secondes -> wait_seconds