miner: support builder-proposed block with validator blind signing by flywukong · Pull Request #3691 · bnb-chain/bsc

flywukong · 2026-05-13T10:56:26Z

Description

This PR adds validator-side support for Builder-Proposed Block with Validator Blind Signin mev flow (bep-675)

It adds the full BidBlock path: builder submission, validator admission, pre-seal validation, bind-signing of unsigned system transactions, BidBlock selection, post-insert GasFee validation, and local permission revoke on dishonest or malformed BidBlocks.

Main Changes

Add BidBlock RPC admission, permission control, and local revoke/fallback behavior.
Add validator-side BidBlock selection and candidate retry alongside local block and legacy SendBid.
Add Parlia support for builder-produced unsigned system transactions and validator bind-signing.
Add builder-facing helpers for BidBlock header preparation and unsigned block assembly.

Rationale

tell us why we need these changes...

Example

[Eth.Miner.Mev]
Enabled = true
BidBlockEnabled = true

Validator need to add config BidBlockEnabled to support new bid path

Changes

Notable changes:

add each change in a bullet point here
...

hashdit-bot · 2026-05-18T05:00:38Z

Pull Request Review

This PR introduces a new BidBlock (builder-proposed block) flow for Parlia/MEV, including RPC admission (mev_sendBidBlock), deterministic pre-seal checks, validator bind-signing of unsigned system transactions, candidate selection, and post-insert verification. It refactors system transaction handling into explicit modes (importing/mining/packing), adds permission revocation mechanics for misbehaving builders, and integrates these paths through miner, worker, API backend, and ethclient layers. It also adds comprehensive tests for unsigned system-tx assembly, deterministic BidBlock timing, permission lifecycle, and commit behavior.

Sensitive Content

No sensitive content detected.

Security Issues

🟠 [HIGH] BidBlock is broadcast before full verification, enabling potential invalid block propagation

File: miner/worker.go
In handleBidBlockResult, the code posts core.NewMinedBlockEvent (broadcast path) before running InsertChain verification and GasFee validation. This means a malformed or invalid BidBlock can be propagated to peers before local full validation fails, which can be abused for network-level spam/amplification and trust degradation.
Recommendation: Perform full local verification (InsertChain + BidBlock-specific post checks) before emitting mined block events to the network, or gate broadcasting behind a successful verification result.

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-04T09:47:45Z

Pull Request Review

This PR introduces validator-side support for BEP-675 builder-proposed BidBlocks with blind-signing flow, including new RPCs (mev_sendBidBlock, permission/status APIs), BidBlock decoding/validation, system-tx whitelist/order checks, and miner-side bidblock selection plus fallback to legacy SendBid. It also refactors Parlia block preparation/finalization paths to support unsigned system transaction packing and later bind-signing, while adding MEV block source tagging (v1/v2) in block metadata and tooling visibility (eth_getBlockMevInfo, jsutils updates). Additionally, it adds in-memory per-builder BidBlock permission revocation management with admin override endpoints and extensive unit tests around permissions, blob validation, and BidBlock assembly behavior.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-04T09:47:51Z

Pull Request Review

This PR introduces comprehensive validator-side support for BEP-675 BidBlock flow, including new mev_sendBidBlock handling, pre-seal validation, blind-signing of unsigned system transactions, bid selection logic, post-insert verification, and per-builder permission revocation controls. It also refactors Parlia block preparation/finalization paths to support packing unsigned system txs for builder-proposed blocks while preserving deterministic header construction and adds block-level MEV source tagging (v1 legacy bid vs v2 bidblock). In addition, it expands RPC/admin/client surfaces and status tooling to expose BidBlock submission, permission state, and block MEV attribution.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-08T09:27:11Z

Pull Request Review

This PR introduces validator-side support for BEP-675 SendBidBlock (builder-proposed block + validator blind signing), adding new bid-block data structures, RPC endpoints, admission/pre-seal verification, system-tx bind-signing flow, and miner-side block selection/fallback logic. It also adds a per-builder BidBlock permission/revocation manager with admin controls and public query APIs, plus MEV path attribution/tagging (v1 vs v2) exposed via new RPCs and client helpers. Additionally, the PR refactors Parlia system transaction handling with explicit modes (importing/mining/packing), improves header preparation for BidBlock flow, and extends tests/metrics around the new pipeline.

Sensitive Content

Blockchain Address:

0xA8caEc0D68a90Ac971EA1aDEFA1747447e1f9871 in cmd/jsutils/getchainstatus.js — hardcoded builder mapping entry
0x2000000000000000000000000000000000000000 in consensus/parlia/parlia_test.go — validator address literal in test code (test file; ignored per policy)
0x0000000000000000000000000000000000001000 in consensus/parlia/parlia_test.go — system contract address in expected trace (test file; ignored per policy)

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-08T09:27:16Z

Pull Request Review

This PR introduces validator-side support for BEP-675 Builder-Proposed Blocks with blind signing, including new mev_sendBidBlock flow, bidblock pre-seal validation, unsigned system transaction handling, and post-seal verification/revocation logic. It adds new MEV APIs and types for bidblock submission, permission status, block-source attribution (v1 vs v2), and admin controls for builder bidblock permissions. It also refactors Parlia block preparation/finalization paths to support separate system transaction modes (importing/mining/packing) and extends tooling/tests to track and validate the new path.

Sensitive Content

Blockchain Address:

0x2000000000000000000000000000000000000000 in consensus/parlia/parlia_test.go — hardcoded test validator address (in test file, ignored per policy)
0xA8caEc0D68a90Ac971EA1aDEFA1747447e1f9871 in cmd/jsutils/getchainstatus.js — builder mapping address

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-16T07:26:44Z

Pull Request Review

This PR adds full validator-side support for BEP-675 BidBlock flow, including new mev_sendBidBlock handling, BidBlock pre-seal validation, unsigned system-tx bind-signing, block-source tagging (v1/v2), and builder permission/revocation controls. It also refactors Parlia block preparation/finalization paths to support packing unsigned system transactions for builder-proposed blocks while preserving normal mining/import behavior through explicit system transaction modes. Additional RPC/admin/client APIs and metrics were introduced for BidBlock permission management and MEV attribution/observability.

Sensitive Content

Blockchain Address:

0x317aB60A0815F8Db2e6cb3f302C152d2A5ef4854 (Ethereum address) in core/types/block_mev_info_test.go — test round-trip builder address
0xA8caEc0D68a90Ac971EA1aDEFA1747447e1f9871 (Ethereum address) in cmd/jsutils/getchainstatus.js — builder map entry

No private keys, mnemonic phrases, or social accounts detected in newly added non-test files.

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-16T07:26:47Z

Pull Request Review

This PR introduces BEP-675 BidBlock support end-to-end in a Go-based Ethereum client/miner stack (Parlia/BSC context), including new RPCs (mev_sendBidBlock, permission/status APIs), BidBlock admission/pre-seal checks, unsigned system-tx handling with validator bind-signing, and selection/fallback logic between local blocks, legacy SendBid, and BidBlock. It also adds block MEV attribution tagging/decoding via header.RequestsHash and expands miner/worker flows to verify selected BidBlocks post-seal with automatic builder permission revocation on malformed/dishonest submissions. Additional tooling and tests were added across consensus, miner, ethapi, and client layers, plus status reporting updates in getchainstatus.js.

Sensitive Content

Blockchain Address:

0xA8caEc0D68a90Ac971EA1aDEFA1747447e1f9871 (Ethereum address) in cmd/jsutils/getchainstatus.js — builder mapping entry (blockroute)

No private keys, mnemonic phrases, or secret key material newly added in non-test files.

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-17T01:19:38Z

Pull Request Review

This PR introduces validator-side support for BEP-675 BidBlock flow, including new RPCs (mev_sendBidBlock, permission query/admin controls), BidBlock decoding/signature recovery, pre-seal validation, system transaction bind-signing, and miner-side BidBlock selection/fallback behavior. It also refactors Parlia block preparation/finalization paths to support unsigned system tx packing for builder-proposed blocks and adds MEV path tagging (v1/v2) into block metadata plus related status/reporting APIs. A broad set of tests was added for BidBlock validation, permission manager behavior, transaction mode handling, and MEV info encoding/decoding.

Sensitive Content

Blockchain Address:

0xA8caEc0D68a90Ac971EA1aDEFA1747447e1f9871 (Ethereum address) in cmd/jsutils/getchainstatus.js — builder mapping entry.
0x317aB60A0815F8Db2e6cb3f302C152d2A5ef4854 (Ethereum address) in core/types/block_mev_info_test.go — test data.
0x3000000000000000000000000000000000000003 (Ethereum address) in consensus/parlia/parlia_test.go — test data.
0x1000000000000000000000000000000000000001 (Ethereum address) in consensus/parlia/parlia_test.go — test data.
0x2000000000000000000000000000000000000002 (Ethereum address) in consensus/parlia/parlia_test.go — test data.
0x2000000000000000000000000000000000000000 (Ethereum address) in consensus/parlia/parlia_test.go — test data.

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-17T02:57:38Z

Pull Request Review

This PR introduces full validator-side support for BEP-675 BidBlock flow in a Go-based blockchain client (Parlia/BNB chain stack), including new mev_sendBidBlock admission, pre-seal validation, unsigned system-tx bind-signing, selection/commit logic, and post-insert verification with builder revocation controls. It also adds MEV path attribution (v1 vs v2) encoded in block headers and new RPC/client/admin surfaces to query block MEV info and manage per-builder BidBlock permissions. In addition, miner internals were refactored to support system transaction modes (importing/mining/packing), with broad test coverage for BidBlock processing, permission windows, and blob validation behavior.

Sensitive Content

Blockchain Address:

0xA8caEc0D68a90Ac971EA1aDEFA1747447e1f9871 in cmd/jsutils/getchainstatus.js — builder map entry
0x317aB60A0815F8Db2e6cb3f302C152d2A5ef4854 in core/types/block_mev_info_test.go — test address (not a finding if treated strictly as test-only file)
Multiple fixed addresses in non-test code paths (e.g., 0x1000...0001, 0x2000...0002) appear in test files only and are excluded per rules.

Private Key / Seed Phrase / Mnemonic / Secret Material:

b71c...f291 (Private Key) in consensus/parlia/parlia_test.go — hardcoded test key material (in test file; excluded per rules, listed for awareness only)

Security Issues

🟡 [MEDIUM] Unauthenticated admin RPC method can change builder permissions (confirm RPC exposure/auth is enforced)

File: eth/api_admin.go, internal/web3ext/web3ext.go
A new admin API admin_setBidBlockPermission(builder, allowed) is introduced without an explicit in-method auth check. In go-ethereum this is typically protected by RPC namespace exposure and transport-level controls, but if admin namespace is accidentally exposed over untrusted interfaces, an attacker could revoke/restore builders and affect MEV flow availability.
Recommendation: Confirm admin namespace is restricted to trusted local/admin channels only, and consider adding explicit operator-auth guardrails or audit logs around permission mutation calls.

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

hashdit-bot · 2026-06-17T03:27:40Z

Pull Request Review

This PR introduces validator-side BEP-675 BidBlock support across the miner, Parlia consensus, RPC/API surface, and client bindings, including admission checks, system-tx bind-signing flow, BidBlock selection, and permission revoke/restore mechanics for misbehaving builders. It also adds block-level MEV attribution tagging (v1 SendBid vs v2 SendBidBlock), new MEV RPC methods (mev_sendBidBlock, mev_getBidBlockPermission, eth_getBlockMevInfo), and admin controls for builder permissions. A substantial set of tests was added to cover BidBlock system-tx shape verification, signing modes, permission lifecycle behavior, and gas-price/blob validation paths.

Sensitive Content

Blockchain Address:

0xA8caEc0D68a90Ac971EA1aDEFA1747447e1f9871 in cmd/jsutils/getchainstatus.js — builder mapping entry
0x3000000000000000000000000000000000000003 in consensus/parlia/parlia_test.go — hardcoded address in new test case (not reported as sensitive finding if strictly test-only)
0x1000000000000000000000000000000000000001 in consensus/parlia/parlia_test.go — hardcoded address in new test case (test-only)
0x2000000000000000000000000000000000000002 in consensus/parlia/parlia_test.go — hardcoded address in new test case (test-only)
0x2000000000000000000000000000000000000000 in consensus/parlia/parlia_test.go — hardcoded address in new test case (test-only)

Security Issues

No serious security issues detected.

Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

zlacfzy · 2026-05-25T08:40:25Z

+) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	m.revoked[builder] = BidBlockRevokeRecord{


Do we need prune this map every day?

zlacfzy · 2026-05-25T08:41:49Z

+	//   - Tx precheck failures (nonce, balance, signature, intrinsic gas, ...)
+	//   - System tx value / params (e.g. deposit value vs. SystemAddress balance)
+	//   - Blob sidecar checks (KZG proofs, blob hashes)
+	if _, err := w.chain.InsertChain(types.Blocks{block}); err != nil {


Do we need check the err if it cause by bid?

zlacfzy · 2026-05-26T07:11:32Z

+	}
+
+	bidBlockFee := uint256.MustFromBig(bidBlock.GasFee)
+	bidBlockValidatorReward := new(uint256.Int).Mul(bidBlockFee, uint256.NewInt(*w.config.Mev.ValidatorCommission))


validatorCommission could be nil?

zlacfzy · 2026-05-26T09:15:23Z

+	BlockHash   *common.Hash    `json:"blockHash,omitempty"`
+	BlockNumber *hexutil.Uint64 `json:"blockNumber,omitempty"`
+	RevokedAt   *time.Time      `json:"revokedAt,omitempty"`
+	ResetAt     time.Time       `json:"resetAt"`


Why not same as 'BidBlockPermissionResult' in api_mev.go'

zlacfzy · 2026-05-27T07:06:36Z

+	case b.newBidBlockCh <- newBidBlockPackage{bidBlock: block, feedback: replyCh}:
+		b.AddPending(block.BlockNumber(), block.Builder, block.Hash())
+	case <-timer.C:
+		return types.ErrMevBusy


Suggested change

return types.ErrMevBusy

return types.ErrMevBusy

case <-ctx.Done():

return ctx.Err()

zlacfzy · 2026-05-27T07:08:16Z

+
+// sendBidBlock queues a decoded BidBlock for selection.
+func (b *bidSimulator) sendBidBlock(_ context.Context, block *types.DecodedBidBlock) error {
+	timer := time.NewTimer(1 * time.Second)


Use a const value?

flywukong marked this pull request as draft May 13, 2026 10:56

flywukong force-pushed the bep-675 branch 3 times, most recently from b7c3533 to f18a70a Compare May 14, 2026 03:06

flywukong changed the title ~~miner: add BidBlock zero-simulate path~~ May 14, 2026

flywukong changed the title ~~miner: support bidblock mev path in bep-675~~ May 14, 2026

flywukong changed the title ~~feat: support builder-proposed block with validator blind signing~~ May 14, 2026

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/feynmanfork.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go

allformless reviewed May 15, 2026

View reviewed changes

Comment thread consensus/parlia/ramanujanfork.go Outdated

This comment was marked as resolved.

Sign in to view

allformless added this to the v1.7.4 milestone May 18, 2026

allformless reviewed May 18, 2026

View reviewed changes

Comment thread consensus/parlia/bid_block.go Outdated

allformless reviewed May 18, 2026

View reviewed changes

Comment thread consensus/parlia/bid_block.go Outdated

allformless reviewed May 18, 2026

View reviewed changes

Comment thread miner/bid_simulator.go Outdated

allformless reviewed May 18, 2026

View reviewed changes

Comment thread consensus/parlia/feynmanfork.go Outdated

allformless reviewed May 18, 2026

View reviewed changes

Comment thread consensus/parlia/parlia.go Outdated

This comment was marked as resolved.

Sign in to view

flywukong dismissed allformless’s stale review via f11b40b June 4, 2026 09:47

allformless previously approved these changes Jun 4, 2026

View reviewed changes

mev: add bid block hash tracing

56511b1

flywukong dismissed allformless’s stale review via 56511b1 June 8, 2026 09:26

allformless previously approved these changes Jun 8, 2026

View reviewed changes

allformless added the Pasteur label Jun 10, 2026

test: cover BidBlock consensus edge cases

c525051

flywukong dismissed allformless’s stale review via c525051 June 16, 2026 07:26

allformless previously approved these changes Jun 16, 2026

View reviewed changes

miner: add BidBlock migration metrics

d3e7362

flywukong dismissed allformless’s stale review via d3e7362 June 17, 2026 01:19

miner: gate BidBlock on Pasteur fork and default-enable

ad867d9

allformless reviewed Jun 17, 2026

View reviewed changes

Comment thread miner/miner_mev.go Outdated

miner: fold Pasteur gate into BidBlock enablement

76182ef

allformless approved these changes Jun 17, 2026

View reviewed changes

zlacfzy approved these changes Jun 17, 2026

View reviewed changes

allformless merged commit 3150087 into bnb-chain:develop Jun 17, 2026
7 of 8 checks passed

allformless mentioned this pull request Jun 17, 2026

release: prepare for release v1.7.4 #3729

Merged

chee-chyuan mentioned this pull request Jun 26, 2026

feat(miner): switch BidBlock to zero-simulate (broadcast-then-verify) bnb-chain/reth-bsc#419

Merged

chee-chyuan mentioned this pull request Jul 9, 2026

fix(consensus): stop validating requests hash content post-execution bnb-chain/reth-bsc#431

Merged

2019jack mentioned this pull request Jul 27, 2026

v1.7.7 validator seals out-of-turn blocks racing delayed in-turn blocks, gets stuck on its own minority fork ("Re-queue blocks" loop) and then misses its own turns — slash counter +40 within 3.5 h of upgrading #3771

Closed

Conversation

flywukong commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Rationale

Example

Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

hashdit-bot Bot commented May 18, 2026

Pull Request Review

Sensitive Content

Security Issues

Security Issues

This comment was marked as resolved.

hashdit-bot Bot commented Jun 4, 2026

Pull Request Review

Sensitive Content

Security Issues

hashdit-bot Bot commented Jun 4, 2026

Pull Request Review

Sensitive Content

Security Issues

hashdit-bot Bot commented Jun 8, 2026

Pull Request Review

Sensitive Content

Security Issues

hashdit-bot Bot commented Jun 8, 2026

Pull Request Review

Sensitive Content

Security Issues

hashdit-bot Bot commented Jun 16, 2026

Pull Request Review

Sensitive Content

Security Issues

hashdit-bot Bot commented Jun 16, 2026

Pull Request Review

Sensitive Content

Security Issues

hashdit-bot Bot commented Jun 17, 2026

Pull Request Review

Sensitive Content

Security Issues

hashdit-bot Bot commented Jun 17, 2026

Pull Request Review

Sensitive Content

Security Issues

Uh oh!

hashdit-bot Bot commented Jun 17, 2026

Pull Request Review

Sensitive Content

Security Issues

zlacfzy May 25, 2026

Choose a reason for hiding this comment

zlacfzy May 25, 2026

Choose a reason for hiding this comment

zlacfzy May 26, 2026

Choose a reason for hiding this comment

zlacfzy May 26, 2026

Choose a reason for hiding this comment

zlacfzy May 27, 2026

Choose a reason for hiding this comment

flywukong commented May 13, 2026 •

edited

Loading