improved prompting, fixed extract #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filip-michalsky
approved these changes
Mar 11, 2025
| }, | ||
| }, | ||
| required: ["action"], | ||
| }, | ||
| }, | ||
| { | ||
| name: "stagehand_extract", | ||
| description: `Extracts structured data from the web page based on an instruction and a JSON schema.`, | ||
| description: `Extracts structured data from the web page based on an instruction and a JSON schema (Zod schema). Extract works best for extracting TEXT in a structured format.`, |
There was a problem hiding this comment.
its absolutely crazy this prompt update made this work lol
There was a problem hiding this comment.
right? are we good to merge?
There was a problem hiding this comment.
@miguelg719 yes good to merge this. I am now working on:
- Using resources for async result loading. It seems that Claude, for example, makes the request to the MCP server and if it takes x amount of time it will try to continuously call the resources to get the updated result. This might fix timeout errors w/ inspector and other clients.
- Test with cline. Here's a guide on how to test it and would be great to sync w/ Sophie once we integrate it as an MCP server to come up with use cases that can be advertised together. I think that the improvements will make Cline perform much better
will open a new PR!
There was a problem hiding this comment.
yup, that's what I saw with claude! perfect
miguelg719
commented
Mar 12, 2025
| @@ -382,20 +391,13 @@ async function handleToolCall( | |||
| schema: zodSchema, | |||
| useTextExtract: true, | |||
| }); | |||
| if (!data || typeof data !== "object" || !("data" in data)) { | |||
There was a problem hiding this comment.
@filip-michalsky this was also causing an issue with extract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract now works, refined prompting a bit. Other potential improvements:
currently: