Skip to content

Chore: Cleanup fields for Pydantic #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

kamath
Copy link
Member

@kamath kamath commented Oct 29, 2024

Migrating our API endpoint caused breaking changes in schema contract. This patches that

@kamath kamath changed the title make all fields optional to avoid loud breaking changes; if people have errors they should use new SDK Oct 29, 2024
@kamath kamath changed the title Chore: All fields are now optional to allow Pydantic to fail silently Oct 31, 2024
@kamath kamath requested a review from maxbeatty October 31, 2024 00:28
@kamath kamath merged commit 0a717b2 into main Oct 31, 2024
@kamath kamath deleted the anirudh/make-all-fields-optional branch October 31, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants