Dylan footer improvements#641
Closed
DylanAustin-TheDreamer wants to merge 2 commits intobuddhist-uni:mainfrom
Closed
Dylan footer improvements#641DylanAustin-TheDreamer wants to merge 2 commits intobuddhist-uni:mainfrom
DylanAustin-TheDreamer wants to merge 2 commits intobuddhist-uni:mainfrom
Conversation
✅ Deploy Preview for obu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Hm... The box around the hero text is confusing considering the other boxes above are clickable, the social media links are now a jumbled mess, and the careful spacing of the background images is ruined. If you want to submit a subsequent PR just centering the site name in the footer, that's a reasonable change, but I don't think the rest of this PR is a good idea and so I'll go ahead and close it "no merge." But! Thanks for splitting it out into its own PR so that I can consider it on its own and congratulations on getting your dev environment working :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently had a look at home page, footer and navbar improvements - And this branch is solely about footer improvements, also updates hero text just above the footer on home page, in the same scss file.
All that happens with the footer is - It attains better symmetry across large screens and mobile devices. A little styling with flex properties and borders, but this compliments its symmetry.