Dylan noresults feature#644
Closed
DylanAustin-TheDreamer wants to merge 2 commits intobuddhist-uni:mainfrom
Closed
Dylan noresults feature#644DylanAustin-TheDreamer wants to merge 2 commits intobuddhist-uni:mainfrom
DylanAustin-TheDreamer wants to merge 2 commits intobuddhist-uni:mainfrom
Conversation
✅ Deploy Preview for obu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
khemarato
requested changes
Mar 26, 2026
Collaborator
khemarato
left a comment
khemarato
left a comment
There was a problem hiding this comment.
Let's wait on this until you have the search functions merged. Once we can reliably tell if a query is trying to find a sutta, then we can think about what we want to do if we can't find that sutta for the user in our DB. 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have changed the return for no search results in search_functions.js
I simply return html elements with buttons for sutta finder and sutta central.
There is another branch edit with the CSS for these buttons on branch -> dylan-search-css