Mangle the name of rustix::runtime to discourage users.#1633
Open
sunfishcode wants to merge 1 commit into
Open
Mangle the name of rustix::runtime to discourage users.#1633sunfishcode wants to merge 1 commit into
rustix::runtime to discourage users.#1633sunfishcode wants to merge 1 commit into
Conversation
There have been a few bug reports from users appearing to use `rustix::runtime` as if it were a normal library feature. It is not. Since the comments in the file don't seem to be sufficient for discouraging users, add a random string to the module name. This would be a semver break, except that `rustix::runtime` has always been `doc(hidden)` and commented as experimental.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a few bug reports from users appearing to use
rustix::runtimeas if it were a normal library feature. It is not. Since the comments in the file don't seem to be sufficient for discouraging users, add a random string to the module name.This would be a semver break, except that
rustix::runtimehas always beendoc(hidden)and commented as experimental.