Ensure reproducible builds when building with Bazel#1640
Open
mgeisler wants to merge 1 commit into
Open
Conversation
The build script would write a rustc `--emit=metadata` file into `OUT_DIR` purely to test whether a snippet compiles. Since the metadata is not stable, this file could vary from run to run. When building with Bazel, which hashes the content of the files in `OUT_DIR`, the leftover file makes every build have a different cache key. This in turn defeats remote caching for the subtree of build graph below `rustic`. This PR simply deletes the throwaway probe artifact before the build script exits so `OUT_DIR` is reproducible.
Author
|
Hi there! I looked briefly at the build failures and I think they are unrelated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build script would write a rustc
--emit=metadatafile intoOUT_DIRpurely to test whether a snippet compiles. Since the metadata is not stable, this file could vary from run to run.When building with Bazel, which hashes the content of the files in
OUT_DIR, the leftover file makes every build have a different cache key. This in turn defeats remote caching for the subtree of build graph belowrustic.This PR simply deletes the throwaway probe artifact before the build script exits so
OUT_DIRis reproducible.