FIX: Fixes update-database script on the last few days of a month. #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the
ghost
suggested changes
Oct 29, 2021
Comment on lines
122
to
128
| url += str(months[i]) + "/RIBS/" | ||
| response = session.get(url) | ||
| pattern = re.compile(r"href=\"(rib\.\d{8}\.\d{4}\.bz2)\"") | ||
| days = pattern.findall(response.text) | ||
| days.sort(reverse=True) | ||
| if days: |
There was a problem hiding this comment.
Suggested change
| url += str(months[i]) + "/RIBS/" | |
| response = session.get(url) | |
| pattern = re.compile(r"href=\"(rib\.\d{8}\.\d{4}\.bz2)\"") | |
| days = pattern.findall(response.text) | |
| days.sort(reverse=True) | |
| if days: | |
| new_url = url + str(months[i]) + "/RIBS/" | |
| response = session.get(new_url) | |
| pattern = re.compile(r"href=\"(rib\.\d{8}\.\d{4}\.bz2)\"") | |
| days = pattern.findall(response.text) | |
| days.sort(reverse=True) | |
| if days: | |
| url = new_url |
Otherwise we end up with no result as http://archive.routeviews.org/route-views4/bgpdata/2021.11/RIBS/2021.10/RIBS/ is queried.
Contributor
Author
There was a problem hiding this comment.
Thanks! Sorry about bad PR. Should be fixed now.
gethvi
force-pushed
the
asn-update-database-fix
branch
from
e3a1d7a to
d8ff651
Compare
sebix
approved these changes
Nov 26, 2021
Member
sebix
left a comment
sebix
left a comment
There was a problem hiding this comment.
The Pull Request looks semantically OK. The PR can be merged as soon as someone reviews and validates the exact code changes and documents the change in the changelog.
waldbauer-certat
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2088.